Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of permission 777 directories #4922

Open
adamnovak opened this issue May 9, 2024 · 0 comments
Open

Get rid of permission 777 directories #4922

adamnovak opened this issue May 9, 2024 · 0 comments

Comments

@adamnovak
Copy link
Member

adamnovak commented May 9, 2024

Toil uses a make_public_dir() function to make world-writable directories to use as temp directories in the worker and the file store implementations, like this:

self.localTempDir: str = make_public_dir(self.localTempDir, suggested_name="job")

It's clear that we intended to do this. It's not clear to me why we intended to do this (maybe to solve Docker-related permission issues?), or that it's actually necessary. It's definitely a good way to have security problems in a multi-tenant environment.

We should stop doing this.

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant