Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle leading whitespace in WDL command blocks more correctly #4854

Open
adamnovak opened this issue Mar 28, 2024 · 0 comments · May be fixed by #4891
Open

Handle leading whitespace in WDL command blocks more correctly #4854

adamnovak opened this issue Mar 28, 2024 · 0 comments · May be fixed by #4891
Assignees
Labels

Comments

@adamnovak
Copy link
Member

adamnovak commented Mar 28, 2024

The WDL spec says we need to remove "common leading whitespace". For some reason, as noted in DataBiosphere/wdl-conformance-tests#34, we're apparently removing all whitespace equal to the first indentation level on any line it appears on. If lines dedent out from the leading line, we probably need to not remove any whitespace that isn't common to all the lines.

I think we might be doing this to work around chanzuckerberg/miniwdl#674, but we also might have come up with a better workaround now and can maybe change the behavior?

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant