Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing large files from public buckets scares the users #4867

Open
adamnovak opened this issue Apr 10, 2024 · 0 comments · May be fixed by #4950
Open

Accessing large files from public buckets scares the users #4867

adamnovak opened this issue Apr 10, 2024 · 0 comments · May be fixed by #4950
Assignees

Comments

@adamnovak
Copy link
Member

adamnovak commented Apr 10, 2024

I had someone complain to me that Toil was broken because it logged:

[2024-04-09T13:05:31-0700] [MainThread] [W] [toil.lib.aws.utils] Strategy 1 to get bucket location did not work: An error occurred (AccessDenied) when calling the GetBucketLocation operation: Access Denied
[2024-04-09T13:05:31-0700] [MainThread] [W] [toil.lib.aws.utils] Strategy 2 to get bucket location did not work: An error occurred (AccessDenied) when calling the GetBucketLocation operation: Access Denied
[2024-04-09T13:05:33-0700] [MainThread] [E] [toil.lib.retry] Got a <class 'botocore.exceptions.ClientError'>: An error occurred (403) when calling the HeadBucket operation: Forbidden which is not retriable according to <function retryable_s3_errors at 0x7fed68f4a560>

And then it sat there for several minutes.

What actually happened was that it finally worked out how to access the data in the S3 bucket, but presumably it logged its successes at a lower level than its (often expected) failures. So to the user it looked like something went wrong.

We should maybe buffer all this information about the things that didn't work and not log it if we find a way that does work. Or we should announce at the same log level when we actually start downloading the thing.

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1539

@adamnovak adamnovak linked a pull request May 23, 2024 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant