Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps, handle vulnerablity, and normalize repo #3

Merged
merged 3 commits into from
Mar 20, 2020

Conversation

zarsky-broad
Copy link
Contributor

@zarsky-broad zarsky-broad commented Mar 16, 2020

Additional testing/verification is appreciated...

@zarsky-broad zarsky-broad requested a review from a team March 16, 2020 22:25
Copy link
Contributor

@breilly2 breilly2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me. I checked dep updates and tested locally: create, token, renew, delete (but not cleanup).

package.json Outdated Show resolved Hide resolved
"@hapi/joi": "^16.1.8",
"body-parser": "^1.19.0",
"cors": "^2.8.5",
"express": "^4.17.1",
"googleapis": "^45.0.0",
"googleapis": "^48.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked changelogs (e.g. googleapis/google-api-nodejs-client#1978) and we look good.

"lodash": "^4.17.15",
"uuid": "^3.3.3"
"uuid": "^7.0.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find good changelogs (other than some mention of how to upgrade from v3). Verified only by testing.

@zarsky-broad zarsky-broad merged commit eb71620 into dev Mar 20, 2020
@zarsky-broad zarsky-broad deleted the iz-update-and-normalize branch March 20, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants