Chroma utils #92
Open
Chroma utils #92
+4,978
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api error over api exception in anthropic.py, reworked the embedding function in chroma utils to be more decoupled and have stronger typing, adjust the spacing on the cli tool in guy.py. everything else was my formatter changing strings or spacing.
…api error over api exception in anthropic.py, reworked the embedding function in chroma utils to be more decoupled and have stronger typing, adjust the spacing on the cli tool in guy.py. everything else was my formatter changing strings or spacing.
|
ok i think its ok now? lol sorry! |
cryptoronto
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fell down a rabbit hole and retyped ChromaUtils. I broke the embedding function off into its own base class and added a dictionary of embedding functions to pass the embed name value through to get the correct embedding function with out chained ifel statements which should improve speed and readability.
Corrected a number of type checking issues from variables being declared None and never being assigned a value due to the resolution of different branches of the logic trees.
Reduced the spacing in the cli tool so that the scrolling print out would land within the cli when not at max size.
My formatter changed a bunch of spacing and single quotation marks to double quotation marks in a number of places within the repo, should not affect functionality or readability.
I hope I didnt overstep, feel free to deny the pull request if I did. I try and fix one type issue I notice and it leads me all way down to a base class, then next thing you know ive typed an entire section of the repo. it should be easier to read and have stronger type safety now though.