Spelling #2

jsoref · 2023-02-05T01:54:48Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/android-apps/actions/runs/4094419408#summary-11114296906

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/android-apps/actions/runs/4094419544#summary-11114297087

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2023-02-05T01:55:25Z

...lane-project/Dashlane/src/main/java/com/dashlane/db/CreationModificationDateTableWorker.java

-        private String mLocallyViewdDate;
+        private String mLocallyViewedDate;


I'm not particularly confident about Viewed vs View

jsoref · 2023-02-05T01:57:08Z

dashlane-project/Dashlane/src/main/java/com/dashlane/util/hardwaresecurity/AuthModuleLogger.kt

-        sendUsageLog35("askLgout")
+        sendUsageLog35("askLogout")


It took me a bit, but I've decided that this aren't actually tied to a real third party thing, but they'd probably break log counting. It shouldn't be terribly hard for a backend to merge the two names, and realistically it'll need to handle such things eventually.

That said, I'm happy to drop this or anything else.

jsoref · 2023-02-05T01:58:12Z

dashlane-project/Dashlane/src/main/res/layout/item_section_header.xml

@@ -10,5 +10,5 @@
    android:paddingBottom="11.5dp"
    android:textAppearance="?textAppearanceSubtitle1"
    android:textColor="@color/text_neutral_quiet"
-    tools:text="Passsword Manager"
+    tools:text="Password Manager"
    />


I try not to fix the missing newline at eof warning even though I (like Git and GitHub) dislike it.

Hanging here, I'm renaming the following file. I think I've picked the correct name, but I'm not certain.

jsoref · 2023-02-05T01:59:10Z

dashlane-project/Dashlane/src/main/res/values/string_autofill_onboarding.xml

-    <string name="in_app_login_persistent_notification_message">Dashlane may help you logging in to this app</string>
+    <string name="in_app_login_persistent_notification_message">Dashlane may help you logging into this app</string>


There are differences of opinion about whether log in is a magical verb that should be treated as separate from to. I personally believe that log is a verb and you can log into a thing. If your style owner objects, I'm happy to drop this.

jsoref · 2023-02-05T01:59:41Z

...authenticator/src/main/java/com/dashlane/authenticator/AuthenticatorMultipleMatchesResult.kt

@@ -21,7 +21,7 @@ class AuthenticatorMultipleMatchesResult : DashlaneActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
-        setContentView(R.layout.activity_mutliple_matches_result)
+        setContentView(R.layout.activity_multiple_matches_result)
        setSupportActionBar(findViewById(R.id.toolbar))
        supportActionBar?.apply {
            setDisplayHomeAsUpEnabled(true)


Another renamed file follows

jsoref · 2023-02-05T01:59:51Z

...t/modules/features/csv-import/src/main/java/com/dashlane/csvimport/ImportFromChromeLogger.kt

@@ -64,7 +64,7 @@ class ImportFromChromeLogger(

    fun logCsvImportAddManuallyClicked() = log(
        subtype = "chrome_android_csv",
-        action = "click_add_manually_after_errror_message_onboarding_screen"
+        action = "click_add_manually_after_error_message_onboarding_screen"
    )

    private fun log(


Renamed file follows

jsoref · 2023-02-05T02:00:38Z

...s/nfccardreader/src/main/java/com/github/devnied/emvnfccard/model/enums/CountryCodeEnum.java

-	GG("Guemsey", "GGY", 831),
+	GG("Guernsey", "GGY", 831),


This is fairly notable.

I'm pretty sure it's a reference to https://en.wikipedia.org/wiki/Guernsey

jsoref · 2023-02-05T02:02:38Z

Fwiw, I'm pretty sure this includes the corrections from #1.

Please feel free to take the changes however, I'm not attached to anything in particular. Mostly, I like to use software and not wince when I see typos. (And Dashlane is definitely software I might use or see someone else using...)

Mikescops · 2023-02-05T11:29:43Z

Hello,

Thanks for your typo corrections 👍 indeed we'll merge with #1

Sorry we don't accept contributions on Github for now because we don't have the right tooling to do so yet.
That said we can pickup your changes upstream and mention you as the author so it appears in the next release.

@xfalempin does it seems ok to you?

jsoref added 30 commits February 4, 2023 20:45

spelling: abstract

fefb30d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: account

fe9d053

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: activation

9bc8e17

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: anon

1608ea7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: answer

e26f540

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: apartment

0ef1422

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: bottom

c98050f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: cryptogram

bb2176d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: currency

693f700

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: current

8a9528c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dashboard

ca84830

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: database

042ae23

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dialog

6a70255

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dismiss

162750d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: error

b5e8bb9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: expiry

e7d8db7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: explanation

0c4ebd6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: guernsey

6cc605e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: international

6b81504

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: into

9cd949a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: logout

cf3dca3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: multiple

2e9cd28

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: notification

f4265d2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: onboarding

20fc4a9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: original

51b9a3e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: password

2b6e232

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: recipient

bc662dd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: referral

3ed23d5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: registration

7c09974

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: screenshot

5a006e5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 7 commits February 4, 2023 20:45

spelling: searchable

724a392

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: selection

f39ec3c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: successfully

7396c85

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: timestamp

c5a978b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transactional

a66c63e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: viewed

0312f57

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: without

35de5b7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref commented Feb 5, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #2

Spelling #2

jsoref commented Feb 5, 2023

jsoref Feb 5, 2023

jsoref Feb 5, 2023

jsoref Feb 5, 2023

jsoref Feb 5, 2023

jsoref Feb 5, 2023

jsoref Feb 5, 2023

jsoref Feb 5, 2023

jsoref commented Feb 5, 2023

Mikescops commented Feb 5, 2023

		private String mLocallyViewdDate;
		private String mLocallyViewedDate;

		<string name="in_app_login_persistent_notification_message">Dashlane may help you logging in to this app</string>
		<string name="in_app_login_persistent_notification_message">Dashlane may help you logging into this app</string>

Spelling #2

Are you sure you want to change the base?

Spelling #2

Conversation

jsoref commented Feb 5, 2023

jsoref Feb 5, 2023

Choose a reason for hiding this comment

jsoref Feb 5, 2023

Choose a reason for hiding this comment

jsoref Feb 5, 2023

Choose a reason for hiding this comment

jsoref Feb 5, 2023

Choose a reason for hiding this comment

jsoref Feb 5, 2023

Choose a reason for hiding this comment

jsoref Feb 5, 2023

Choose a reason for hiding this comment

jsoref Feb 5, 2023

Choose a reason for hiding this comment

jsoref commented Feb 5, 2023

Mikescops commented Feb 5, 2023