Remove unused attack type breath enum.
#6411
Conversation
This enum value is unused. Breath spells seem to just be classified as `magical` with the appropriate element. Removing this should alleviate some ambiguity/confusion when trying to use the appropriate value.
|
might possibly have been done with the intent to use it during implementation of how breaths actually should work (based on current/max hp) and just never got done. https://www.bg-wiki.com/bg/Damage_Taken#Breath_Damage_Taken |
|
Would you prefer to leave this value? And, if so, should it be used for BLU breath spells instead of Whatever we decide I can implement it as part of the clean ups. |
|
Nothing stopping us from re-adding it if its actually needed later I spoze, but I'm not decision making either way here. I don't even know if that is needed to implement it, just thought I'd give the score on breath damage. |
|
Understood. I'll leave this PR open then for now. During my audit I'll continue with the existing convention of annotating breath BLU spells as |
This enum value is unused.
Breath spells seem to just be classified as
magicalwith the appropriate element.Removing this should alleviate some ambiguity/confusion when trying to use the appropriate value.
(Found this during an audit of BLU spells for #6225)