This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Add a simple flow to allow changing user passwords. #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prerequisite for DarkstarProject/xiloader#7. There is probably some refactoring that could be done in this file to reduce the amount of nested braces and reduce duplicated code. I tried to touch as little existing code as possible in this change to reduce the risk of introducing a regression.
|
Let me know what folks think of this change. |
|
Here's how things look on the xiloader side: mrhappyasthma/xiloader@6360501 |
|
I'll get with you in a bit so we can launch the changes to the loader at the same time |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for
DarkstarProject/xiloader#7.
This change adds support for a new command in the login code to support changing a users password. It simply verifies the users login similarly to the existing flow, and then makes another request over the socket for the new password. Then it updates the SQL.
Tested locally. Have a set of changes ready for xiloader as well, but this work is required first.
NOTE: There is definitely some refactoring that could be done in this file to
reduce the amount of nested braces and to reduce duplicated code. I tried
to touch as little existing code as possible in this change to reduce
the risk of introducing a regression.