Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main purpose is to fix Issue #103, also cleaned up some imports. #114

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Main purpose is to fix Issue #103, also cleaned up some imports. #114

wants to merge 4 commits into from

Conversation

TheDeafCreeper
Copy link

No description provided.

@TheDeafCreeper TheDeafCreeper changed the title Main purpose is to fix Issue #103, also cleaned up some imports though. Main purpose is to fix Issue #103, also cleaned up some imports. Jan 25, 2023
MenacingPerson
MenacingPerson suggested changes Feb 27, 2023
View reviewed changes
Copy link

@MenacingPerson MenacingPerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it just be

if (hit == null || hit.getType() == null) {
    return defaultColor.getValue();

@TheDeafCreeper
Copy link
Author

That is a good point, I'll change it in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MenacingPerson MenacingPerson MenacingPerson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheDeafCreeper @MenacingPerson