add: tests for CockroachDB #1869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah it seems the CI/CD has moved to Appveyor. I don't see a way to setup CockroachDB through the AppVeyor CI, although I do see configuration for Postgres and MYSQL. Any help there would be appreciated. |
NickCraver
reviewed
Jan 10, 2023
| @@ -23,6 +23,10 @@ jobs: | |||
| POSTGRES_PASSWORD: postgres | |||
| POSTGRES_DB: test | |||
| options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5 | |||
| cockroachdb: | |||
| image: timveil/cockroachdb-single-node:latest | |||
There was a problem hiding this comment.
Let's try and use the official image here please - everything else looks good at a quick glance, but we'd want to rely on the official image in the builds.
NickCraver
reviewed
Jan 10, 2023
| @@ -38,8 +42,15 @@ jobs: | |||
| MYSQL_ROOT_PASSWORD: root | |||
| MYSQL_DATABASE: test | |||
| steps: | |||
|
|
|||
NickCraver
reviewed
Jan 10, 2023
| with: | ||
| dotnet-version: | | ||
| 3.1.x | ||
| 5.0.x |
There was a problem hiding this comment.
Dapper needs a lot of updating love we haven't had time for - this shouldn't be needed, but needs to be paired with a net6.0 update on test projects only (not changing core library targets). We can do that in this PR or separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for CockroachDB. The tests are largely borrowed from the existing PostgreSQL tests to ensure basic functionality. Due to the way SERIAL primary keys work in CockroachDB some tests had to be removed because they were no longer deterministic.
The official CockroachDB docker image cockroachdb/cockroach#83749 has trouble starting in single node mode in Actions CI, so an alternate image had to be used.
Finally, I was running into issues with .NET framework versions missing for 3.x and 5.x so I modified the CI to include those versions.
You can see that the tests pass on my fork here:
https://github.com/dikshant/Dapper/actions/runs/3790538626/jobs/6445231573