Fix ApproxPercentileAccumulator

Dandandan · Mar 12, 2024 · 21c3a11 · 21c3a11
1 parent bd9a272
commit 21c3a11
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/datafusion/physical-expr/src/aggregate/approx_percentile_cont.rs b/datafusion/physical-expr/src/aggregate/approx_percentile_cont.rs
@@ -391,7 +391,7 @@ impl Accumulator for ApproxPercentileAccumulator {
 
     fn evaluate(&mut self) -> Result<ScalarValue> {
         if self.digest.count() == 0.0 {
-            return exec_err!("aggregate function needs at least one non-null element");
+            return Ok(ScalarValue::Null);
         }
         let q = self.digest.estimate_quantile(self.percentile);
 

diff --git a/datafusion/sqllogictest/test_files/aggregate.slt b/datafusion/sqllogictest/test_files/aggregate.slt
@@ -2255,9 +2255,10 @@ select median(a) from (select 1 as a where 1=0);
 ----
 NULL
 
-query error DataFusion error: Execution error: aggregate function needs at least one non-null element
+query I
 select approx_median(a) from (select 1 as a where 1=0);
-
+----
+NULL
 
 # aggregate_decimal_sum
 query RT