Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix person lookup on project submission #2959 #9485

Conversation

Leano1998
Copy link
Contributor

References

Add references/links to any related issues or PRs:

Description

This small PR corrects the direction of Person-Project relationship used in the submission workflow and changes the mapped metadata field in virtual-metadata.xml to project.investigator (before it was dc.contributor.author)

Instructions for Reviewers

The relationship direction used in the project-step of submission-forms.xml for adding persons was wrong. Due to this no persons could be connected to a new project. Additionally the metadata field-mapping created by an existing project-person relation was not work either, because the mapped metadata-field was set to dc.contributor.author, but the submission-form expected it to be project.investigator. I corrected the direction of the relationship to isPersonOfProject in the submission form and changed the mapped metadata fields in the virtual-metadata.xml.

List of changes in this PR:

  • Correct used relationship-type in submission-forms.xml
  • Changed metadata field for isPersonOfProject metadata-mapping.

Include guidance for how to test or review your PR.

  1. Activate entities in your DSpace instance
  2. Create a new Person entity
  3. Create a new Project item for example via MyDSpace page
  4. Connect the created person-entity with your project as an investigator

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug component: submission Related to configurable submission system component: configurable entities Related to Configurable Entities feature 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Apr 19, 2024
@tdonohue tdonohue added this to the 8.0 milestone Apr 19, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Leano1998 ! Tested this today and verified it works now.

@tdonohue tdonohue merged commit f0ade8a into DSpace:main May 13, 2024
19 of 20 checks passed
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

tdonohue added a commit to tdonohue/DSpace that referenced this pull request May 13, 2024
tdonohue added a commit that referenced this pull request May 13, 2024
Fix broken ITs after merger of #9485
github-actions bot pushed a commit that referenced this pull request May 13, 2024
(cherry picked from commit 16343d6)
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 13, 2024
tdonohue added a commit that referenced this pull request May 13, 2024
[Port dspace-7_x] Fix broken ITs after merger of #9485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. bug component: configurable entities Related to Configurable Entities feature component: submission Related to configurable submission system
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Person entity can not be added to a Project
3 participants