New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix person lookup on project submission #2959 #9485
Merged
tdonohue
merged 2 commits into
DSpace:main
from
dspace-unimr:fix-person-lookup-on-project-submission-#2959
May 13, 2024
Merged
Fix person lookup on project submission #2959 #9485
tdonohue
merged 2 commits into
DSpace:main
from
dspace-unimr:fix-person-lookup-on-project-submission-#2959
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
bug
component: submission
Related to configurable submission system
component: configurable entities
Related to Configurable Entities feature
1 APPROVAL
pull request only requires a single approval to merge.
port to dspace-7_x
This PR needs to be ported to `dspace-7_x` branch for next bug-fix release
labels
Apr 19, 2024
tdonohue
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @Leano1998 ! Tested this today and verified it works now.
Successfully created backport PR for |
tdonohue
added a commit
to tdonohue/DSpace
that referenced
this pull request
May 13, 2024
tdonohue
added a commit
that referenced
this pull request
May 13, 2024
Fix broken ITs after merger of #9485
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
(cherry picked from commit 16343d6)
tdonohue
removed
the
port to dspace-7_x
This PR needs to be ported to `dspace-7_x` branch for next bug-fix release
label
May 13, 2024
tdonohue
added a commit
that referenced
this pull request
May 13, 2024
[Port dspace-7_x] Fix broken ITs after merger of #9485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 APPROVAL
pull request only requires a single approval to merge.
bug
component: configurable entities
Related to Configurable Entities feature
component: submission
Related to configurable submission system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs:
Description
This small PR corrects the direction of Person-Project relationship used in the submission workflow and changes the mapped metadata field in virtual-metadata.xml to
project.investigator
(before it wasdc.contributor.author
)Instructions for Reviewers
The relationship direction used in the project-step of submission-forms.xml for adding persons was wrong. Due to this no persons could be connected to a new project. Additionally the metadata field-mapping created by an existing project-person relation was not work either, because the mapped metadata-field was set to
dc.contributor.author
, but the submission-form expected it to beproject.investigator
. I corrected the direction of the relationship to isPersonOfProject in the submission form and changed the mapped metadata fields in the virtual-metadata.xml.List of changes in this PR:
Include guidance for how to test or review your PR.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
pom.xml
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.