Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting of Improve S3 Bitstream Storage to Lazy download object from S3 to 7_x #9484

Merged
merged 2 commits into from May 16, 2024

Conversation

abollini
Copy link
Member

This is the porting of #9477 to the dspace-7_x branch

@tdonohue tdonohue changed the base branch from main to dspace-7_x April 19, 2024 14:05
@tdonohue tdonohue added bug backend: bitstore Related to file/bitstream storage labels Apr 19, 2024
Copy link
Member

@pnbecker pnbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, thank you. I tested the version rebased to DSpace 7 and it works well. Thank you @abollini!

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @abollini ! The code looks good to me. Verified this is identical to #9477

@tdonohue
Copy link
Member

After approving, I realized the automated tests never ran on this PR. Closing & reopening briefly to trigger the tests to run. I just want to verify this passes all tests on 7.x (it should)

@tdonohue tdonohue closed this May 16, 2024
@tdonohue tdonohue reopened this May 16, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone May 16, 2024
@tdonohue tdonohue merged commit 598fb18 into DSpace:dspace-7_x May 16, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: bitstore Related to file/bitstream storage bug high priority
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants