Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore batch templates mail #9433

Merged
merged 2 commits into from May 9, 2024
Merged

Restore batch templates mail #9433

merged 2 commits into from May 9, 2024

Conversation

Bezkup
Copy link
Contributor

@Bezkup Bezkup commented Mar 25, 2024

References

Fixes #9416

Description

Restored and renamed template mails for batch import status

List of changes in this PR:
As above

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug backend: email-system Related to emails sent from DSpace 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Mar 25, 2024
@tdonohue tdonohue self-requested a review May 9, 2024 14:53
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Bezkup ! This fixes a very obvious bug. These email templates need to exist since they are referenced.

@tdonohue tdonohue merged commit c15b580 into DSpace:main May 9, 2024
19 of 20 checks passed
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 9, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. backend: email-system Related to emails sent from DSpace bug
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

The DSpace is trying to send emails from templates that do not exist at all
3 participants