Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The DSpace is trying to send emails from templates that do not exist at all #9416

Closed
milanmajchrak opened this issue Mar 14, 2024 · 3 comments · Fixed by #9433
Closed

The DSpace is trying to send emails from templates that do not exist at all #9416

milanmajchrak opened this issue Mar 14, 2024 · 3 comments · Fixed by #9433
Assignees
@Bezkup
Labels
bug tools: import Related to import of data into the system
Milestone
7.6.2

Comments

@milanmajchrak
Copy link
Contributor

Describe the bug
Version: DSpace7.6.1.
The DSpace is trying to send emails during importing Items from UI which do not exist. That missing templates are:

  • bte_batch_import_success
  • bte_batch_import_error

Code:

To Reproduce
Just check that templates do not exist in the /dspace/config/emails/ folder

Expected behavior
Existing email templates or removed code that uses them.
@milanmajchrak milanmajchrak added bug needs triage New issue needs triage and/or scheduling labels Mar 14, 2024
@tdonohue
Copy link
Member

The code related to these email templates was removed in #3189. So, these lines of code should either be removed entirely, or perhaps replaced with a generic batch_import_error and batch_import_success email templates (if the emails are still useful)>

Pulling this over to the 7.6.x board as it needs a volunteer. Should be an easy fix though.

@tdonohue tdonohue added tools: import Related to import of data into the system good first issue This is a smaller ticket/bug that may be easier for new contributors help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Mar 18, 2024
@Bezkup
Copy link
Contributor

Bezkup commented Mar 25, 2024

Hello! If no one is working on this issue, I'll try to resolve it. Are these email templates still useful? Seems a pity to not use them

@tdonohue
Copy link
Member

@Bezkup : As I noted above, I think these templates can be used but they should be renamed. They are no longer related to BTE (which was removed in #3189). Instead, they should be renamed to something like batch_import_error and batch_import_success

Feel free to create a PR for us if you have time. Thanks!

@Bezkup Bezkup mentioned this issue Mar 25, 2024
Merged
8 tasks
@tdonohue tdonohue removed help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels Mar 25, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bezkup Bezkup

Labels
bug tools: import Related to import of data into the system
Projects
DSpace 7.6.x Maintenance
Status: ✅ Done
Milestone
7.6.2
Development

Successfully merging a pull request may close this issue.

Restore batch templates mail Bezkup/DSpace
3 participants
@tdonohue @Bezkup @milanmajchrak