Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide documentation for DSharpPlus.Commands #1867

Merged
merged 23 commits into from May 2, 2024

Conversation

OoLunar
Copy link
Member

@OoLunar OoLunar commented May 1, 2024

Summary

Provides articles and documentation for the DSharpPlus.Commands package. Additionally obsoletes both the DSharpPlus.CommandsNext and the DSharpPlus.SlashCommands packages.

Notes

Untested.

OoLunar and others added 16 commits April 30, 2024 19:43
- `cd $(ProjectRoot)/docs/`
- `rename "commands" "commands_next" images/commands*.png`
- `grep --files-with-matches -r "commands.*\.png" . | xargs sed -i -r -e "s/commands(.*)\.png/commands\_next\1\.png/g"`
- `mv commands commands_next`
…s.commands_next`.

- `grep --files-with-matches -r "articles.commands." . | xargs sed -i "s/articles.commands./articles.commands_next./g"`
* add a few things to the checks article

* address feedback

* address PR feedback
@OoLunar OoLunar added enhancement commands-next For issues related to DSharpPlus.CommandsNext docs obsolete: slash-commands For issues related to DSharpPlus.SlashCommands commands For issues related to DSharpPlus.Commands labels May 1, 2024
@OoLunar OoLunar requested a review from InFTord May 1, 2024 00:54
@OoLunar OoLunar self-assigned this May 1, 2024
Copy link
Member

@Plerx2493 Plerx2493 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes, otherwise looks good. Thank you for taking the time to write this all

docs/articles/commands/custom_argument_converters.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
@akiraveliara
Copy link
Contributor

where did my section on parameter checks go :c

@akiraveliara akiraveliara removed the commands-next For issues related to DSharpPlus.CommandsNext label May 2, 2024
@akiraveliara akiraveliara merged commit 6187219 into master May 2, 2024
1 check passed
@akiraveliara akiraveliara deleted the oolunar/docs/commands branch May 2, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands For issues related to DSharpPlus.Commands docs enhancement obsolete: slash-commands For issues related to DSharpPlus.SlashCommands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants