Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value is not all invocations use 2 arguments #2554

Merged
merged 1 commit into from
May 15, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented May 14, 2024

This unbreaks the language versions page. Visiting the page triggered the functions without the second argument.

This unbreaks the language versions page. Visiting the page
triggered the functions without the second argument.
@vmcj vmcj added this pull request to the merge queue May 15, 2024
Merged via the queue into DOMjudge:main with commit 0060dba May 15, 2024
19 of 20 checks passed
@vmcj vmcj deleted the fix_versions_page branch May 15, 2024 06:48
@eldering
Copy link
Member

eldering commented May 15, 2024

@vmcj could you please next time try to carefully reread your sentences? The title sentence in this commit/PR does not parse. Even if I replace is by if, then it still doesn't really make sense, because the default value is set independently of arguments being provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants