Versions edit button #2553
Merged
Versions edit button #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
versions_edit_button
branch
6 times, most recently
from
23c65e6
to
757a770
Compare
meisterT
reviewed
May 23, 2024
| try { | ||
| self::assertSelectorExists('a#navbarDropdownContests:contains("no contest")', "Failed at: " . $url); | ||
| } catch (\Exception $e) { | ||
| $gitlabArtifacts = getenv('GITLABARTIFACTS'); |
There was a problem hiding this comment.
Should we put this code into a test helper class?
Also, there is a bunch of phpcs errors here
There was a problem hiding this comment.
I think it's only relevant for the Traversal test so I'm not sure if we'll ever re use it.
vmcj
commented
May 23, 2024
| try { | ||
| self::assertSelectorExists('a#navbarDropdownContests:contains("no contest")', "Failed at: " . $url); | ||
| } catch (\Exception $e) { | ||
| $gitlabArtifacts = getenv('GITLABARTIFACTS'); |
There was a problem hiding this comment.
I think it's only relevant for the Traversal test so I'm not sure if we'll ever re use it.
Try to debug how the failing page looked like in CI. This is only relevant for CI as locally we can reproduce the test or set the environment variable.
Closes: DOMjudge#2533 Although this might be relevant for jury members they don't have access and this is left for admins.
vmcj
force-pushed
the
versions_edit_button
branch
from
7926ff1
to
ea194c5
Compare
meisterT
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure why the unit tests break (the do consistently so it has to be related) but do we want the button like this?
The unit test fails on
/jury/languages/c/editand when I try this locally it does work.Make sure no contest is selected in the menu, visit the versions page, use the button is what the test should do and is what works for my side.