Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in docs that service files are not default installed (in non-FHS). #2346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Feb 25, 2024

No description provided.

@@ -231,3 +231,6 @@ the judgedaemon.
The judgedaemon can also be run as a service by running::

sudo systemctl enable --now domjudge-judgehost

This only works in a FHS install, if the judgehost has been installed with another
option those `service` files have to manually copied to the right directory e.g. `/etc/systemd`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve punctuation:

Suggested change
option those `service` files have to manually copied to the right directory e.g. `/etc/systemd`.
option, those `service` files have to manually copied to the right directory,
e.g. `/etc/systemd`.

@thijskh
Copy link
Member

thijskh commented Feb 28, 2024

I’m all for making docs match reality, but seems to complicatie the instructions and increase mental load. What is the relation with this idea to make the software less complex, instead of the instructions more complex?

@vmcj
Copy link
Member Author

vmcj commented Feb 28, 2024

I’m all for making docs match reality, but seems to complicatie the instructions and increase mental load. What is the relation with this idea to make the software less complex, instead of the instructions more complex?

So you want to leave the documentation as is and mention it after the make install-judgehost step in code?

@thijskh
Copy link
Member

thijskh commented Feb 28, 2024

Yes, as I understand that this is Jaap’s suggestion in the linked issue

@eldering
Copy link
Member

Yes, as I understand that this is Jaap’s suggestion in the linked issue

And also remove the installation of service files for the FHS install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants