Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throbber and data upload #355

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Conversation

NXXR
Copy link
Collaborator

@NXXR NXXR commented Apr 5, 2024

Description

This PR changes the Throbber used for loading suspense across all components of the app.
The PR also adds an upload popup for users to upload case data in the future.
Both the data upload, and sign in menu items in the app menu are disabled, as they are not fully functional yet.

Related Issues

Design Decisions

we decided on the Helix throbber (#22) by Griffin Jhonston as it fits with the health theme of ESID.
The size of the upload status icons was chosen to allow the throbbers to mesh with each other.

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@NXXR NXXR self-assigned this Apr 5, 2024
@NXXR NXXR added class:enhancement New feature or request type:web-frontend labels Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Test Results

39 tests  ±0   39 ✅ ±0   11s ⏱️ ±0s
17 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 6101891. ± Comparison against base commit 8058185.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant