Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/square map #165

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Feature/square map #165

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2022

Known Issues:

  • When switching beetween the maps data will not be shown until you change something (e.g. Date or ActiveSimulation). I think this should be fixed before the merge, but i don't get it.

  • On hover the Data gets hidden (its on a lower layer than the Hover Effect. See comment in squareMap.ts line 218)

created an Issue with Improvements #166

@coveralls
Copy link

coveralls commented Aug 22, 2022

Pull Request Test Coverage Report for Build 2902465775

  • 0 of 110 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.4%) to 18.344%

Changes Missing Coverage Covered Lines Changed/Added Lines %
frontend/src/components/Sidebar/index.tsx 0 1 0.0%
frontend/src/store/services/scenarioApi.ts 0 9 0.0%
frontend/src/components/Sidebar/Maps.tsx 0 12 0.0%
frontend/src/components/Sidebar/SquareMap.tsx 0 88 0.0%
Totals Coverage Status
Change from base Build 2759672471: -2.4%
Covered Lines: 231
Relevant Lines: 1007

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Aug 22, 2022

Unit Test Results

  1 files  ±0  12 suites  ±0   35s ⏱️ +6s
30 tests ±0  30 ✔️ ±0  0 💤 ±0  0 ±0 
31 runs  ±0  31 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit adb5d60. ± Comparison against base commit 35e66a3.

♻️ This comment has been updated with latest results.

@ghost
Copy link
Author

ghost commented Aug 26, 2022

rename Tab Header: Ausgewähltes Szenario, Szenariovergleich (+localisation)

@NXXR NXXR marked this pull request as draft October 5, 2022 08:52
@NXXR
Copy link
Collaborator

NXXR commented Oct 5, 2022

don't merge until first release

@NXXR NXXR linked an issue Oct 5, 2022 that may be closed by this pull request
@NXXR NXXR linked an issue Oct 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D grid of Districts with most geographic accuracy
2 participants