-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of VaryingCelestialTransform #370
Conversation
CodSpeed Performance ReportMerging #370 will improve performances by ×2.9Comparing Summary
Benchmarks breakdown
|
WHAT THAT WAS NOT THE EFFING POINT 🤦 |
hahaha |
Ok that's much closer to what I expected. I declare this PR ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improvements from DKISTDC#370
Slightly re-jig VaryingCelestialTransform to strip units from the inputs in
._map_transform()
and then put them back afterwards. Gives a reasonable performance boost, about 3.5x faster to plot a dataset across non-optimal axes.