Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor transfer_complete_datasets for one transfer job #340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Mar 5, 2024

fixes #339

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 97.55%. Comparing base (788bfd9) to head (300fa04).

Files Patch % Lines
dkist/net/helpers.py 91.42% 3 Missing ⚠️
dkist/net/globus/transfer.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   97.73%   97.55%   -0.19%     
==========================================
  Files          34       34              
  Lines        1990     2005      +15     
==========================================
+ Hits         1945     1956      +11     
- Misses         45       49       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dkist/net/globus/transfer.py Outdated Show resolved Hide resolved
@Cadair Cadair marked this pull request as ready for review March 5, 2024 15:51
This changes it to only do one globus task rather than one per dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transfer_complete_datasets should only start one transfer job per call
1 participant