fix(route): fix /twitter/likes

[ZhangChunXian]

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/twitter/likes/Diygod

New RSS Route Checklist / 新 RSS 路由检查表

• New Route / 新的路由
  • Follows [Script Standard](https://docs.rsshub.app/joinus/advanced/script-standard) / 跟随 [路由规范](https://docs.rsshub.app/zh/joinus/advanced/script-standard)
• Anti-bot or rate limit / 反爬/频率限制
  • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
• [Date and time](https://docs.rsshub.app/joinus/advanced/pub-date) / [日期和时间](https://docs.rsshub.app/zh/joinus/advanced/pub-date)
  • Parsed / 可以解析
  • Correct time zone / 时区正确
• New package added / 添加了新的包
• Puppeteer

Note / 说明

Fixed routes /twitter/likes

[github-actions]

Please use actual values in routes section instead of path parameters.
请在 routes 部分使用实际值而不是路径参数。

[github-actions]

Please use actual values in routes section instead of path parameters.
请在 routes 部分使用实际值而不是路径参数。

[github-actions]

Successfully generated as following:

http://localhost:1200/twitter/likes/Diygod - Failed ❌

HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/><code class="mt-2 block max-h-28 overflow-auto bg-zinc-100 align-bottom w-fit details">ConfigNotFoundError: Twitter API is not configured</code>
Route: <code class="ml-2 bg-zinc-100">/twitter/likes/:id/:routeParams?</code>
Full Route: <code class="ml-2 bg-zinc-100">/twitter/likes/Diygod</code>
Node Version: <code class="ml-2 bg-zinc-100">v21.7.3</code>
Git Hash: <code class="ml-2 bg-zinc-100">97935176</code>

[TonyRL]

This error occurs when I tested with /twitter/likes/DIYgod with valid TWITTER_COOKIE set.

RSSHub/lib/routes/twitter/api/web-api/utils.ts

Line 66 in bac8af6

instructions = data.user.result.timeline_v2.timeline.instructions;

error: Error in /twitter/likes/DIYgod: TypeError: TypeError: Cannot read properties of undefined (reading 'instructions')
    at paginationTweets (RSSHub/lib/routes/twitter/api/web-api/utils.ts:66:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at <anonymous> (RSSHub/lib/routes/twitter/api/web-api/api.ts:103:13)
    at Object.tryGet (RSSHub/lib/utils/cache/index.ts:84:27)
    at Object.handler (RSSHub/lib/routes/twitter/likes.ts:42:16)

[ZhangChunXian]

config TWITTER_USERNAME, TWITTER_PASSWORD and TWITTER_COOKIE are necessary. Do you have the correct router /twitter/likes/Diygod configurations? If not, please use another Twitter account to test. I use my own Twitter account and configurations when I test locally.

[TonyRL]

config TWITTER_USERNAME, TWITTER_PASSWORD and TWITTER_COOKIE are necessary.

RSSHub/lib/routes/twitter/api/index.ts

Lines 6 to 7 in e579392

	const enableMobileApi = config.twitter.username && config.twitter.password;
	const enableWebApi = config.twitter.cookie;

RSSHub/lib/routes/twitter/api/index.ts

Lines 36 to 40 in e579392

	if (enableWebApi) {
	api = webApi;
	} else if (enableMobileApi) {
	api = mobileApi;
	}

Only TWITTER_COOKIE is needed for this route. If you provide all 3 of them, TWITTER_COOKIE will take the priority and disregard TWITTER_USERNAME and TWITTER_PASSWORD.

FYI, /twitter/user/DIYgod does work with valid TWITTER_COOKIE set.

---

In fact, if you provide TWITTER_USERNAME and TWITTER_PASSWORD only, which means using mobileApi, the route will not work since it can't find getUserLikes()

RSSHub/lib/routes/twitter/api/mobile-api/api.ts

Line 268 in e579392

// const getUserLikes = (id, params = {}) => cacheTryGet(id, params, getUserLikesByID);

[ZhangChunXian]

This error occurs when I tested with /twitter/likes/DIYgod with valid TWITTER_COOKIE set.

RSSHub/lib/routes/twitter/api/web-api/utils.ts

Line 66 in bac8af6

instructions = data.user.result.timeline_v2.timeline.instructions;

error: Error in /twitter/likes/DIYgod: TypeError: TypeError: Cannot read properties of undefined (reading 'instructions')
    at paginationTweets (RSSHub/lib/routes/twitter/api/web-api/utils.ts:66:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at <anonymous> (RSSHub/lib/routes/twitter/api/web-api/api.ts:103:13)
    at Object.tryGet (RSSHub/lib/utils/cache/index.ts:84:27)
    at Object.handler (RSSHub/lib/routes/twitter/likes.ts:42:16)

I did not encounter the same error. I tested my Twitter account on my own server and locally, and it worked successfully. I installed the dependencies using npm, and then changed the "dev" command to:

cross-env NODE_ENV=dev TWITTER_COOKIE='auth_token=;ct0=' tsx watch --no-cache lib/index.ts
I just added the Twitter cookie.

By the way, I only modified the Web API, I didn't modify the mobile API.

[TonyRL]

Well, the reason of why it didn't work for me is that this is one of the Twitter Premium features.

Screenshot

[ZhangChunXian]

Fine. Could you merge this pull request? I don't have a Premium Twitter account, so I cannot fix this bug.

[TonyRL]

Please throw an exception for situation like #15384 (comment)

[TonyRL]

Suggested change

	{
	name: 'TWITTER_USERNAME',
	description: 'Please see above for details.',
	},
	{
	name: 'TWITTER_PASSWORD',
	description: 'Please see above for details.',
	},

Explained in #15384 (comment)

[github-actions]

Successfully generated as following:

http://localhost:1200/twitter/likes/Diygod - Failed ❌

HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/><code class="mt-2 block max-h-28 overflow-auto bg-zinc-100 align-bottom w-fit details">ConfigNotFoundError: Twitter API is not configured</code>
Route: <code class="ml-2 bg-zinc-100">/twitter/likes/:id/:routeParams?</code>
Full Route: <code class="ml-2 bg-zinc-100">/twitter/likes/Diygod</code>
Node Version: <code class="ml-2 bg-zinc-100">v21.7.3</code>
Git Hash: <code class="ml-2 bg-zinc-100">a4337902</code>

[github-actions]

Successfully generated as following:

http://localhost:1200/twitter/likes/Diygod - Failed ❌

HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/><code class="mt-2 block max-h-28 overflow-auto bg-zinc-100 align-bottom w-fit details">ConfigNotFoundError: Twitter API is not configured</code>
Route: <code class="ml-2 bg-zinc-100">/twitter/likes/:id/:routeParams?</code>
Full Route: <code class="ml-2 bg-zinc-100">/twitter/likes/Diygod</code>
Node Version: <code class="ml-2 bg-zinc-100">v21.7.3</code>
Git Hash: <code class="ml-2 bg-zinc-100">ae82c09e</code>

[ZhangChunXian]

All done, Throw an error for Twitter Premium accounts and delete unnecessary configurations.

[TonyRL]

Suggested change

	if (data && data.user && data.user.result && data.user.result.timeline_v2 && data.user.result.timeline_v2.timeline && data.user.result.timeline_v2.timeline.instructions) {
	if (data?.user?.result?.timeline_v2?.timeline?.instructions) {

[github-actions]

Successfully generated as following:

http://localhost:1200/twitter/likes/Diygod - Failed ❌

HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/><code class="mt-2 block max-h-28 overflow-auto bg-zinc-100 align-bottom w-fit details">ConfigNotFoundError: Twitter API is not configured</code>
Route: <code class="ml-2 bg-zinc-100">/twitter/likes/:id/:routeParams?</code>
Full Route: <code class="ml-2 bg-zinc-100">/twitter/likes/Diygod</code>
Node Version: <code class="ml-2 bg-zinc-100">v21.7.3</code>
Git Hash: <code class="ml-2 bg-zinc-100">3f5c7887</code>