Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dfsu read elements preserve order #690

Merged
merged 29 commits into from
May 24, 2024
Merged

Dfsu read elements preserve order #690

merged 29 commits into from
May 24, 2024

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented May 1, 2024

closes #689

  • 2d
  • 3d
  • Spectral

@ecomodeller ecomodeller marked this pull request as draft May 1, 2024 08:54
@ecomodeller ecomodeller marked this pull request as ready for review May 1, 2024 11:00
@ecomodeller ecomodeller marked this pull request as draft May 1, 2024 11:02
@ecomodeller
Copy link
Member Author

After, consistency between values and coordinates.
image

@ecomodeller ecomodeller marked this pull request as ready for review May 1, 2024 12:18
@ecomodeller
Copy link
Member Author

#632 is related closely to this PR

Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the change on LineSpectrum - maybe you can explain me verbally ?

mikeio/spatial/_FM_geometry.py Show resolved Hide resolved
@jsmariegaard jsmariegaard self-requested a review May 24, 2024 12:52
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ecomodeller ecomodeller merged commit 683276f into main May 24, 2024
6 checks passed
@ecomodeller ecomodeller deleted the fix/dfsu_read_elements branch May 24, 2024 13:36
@ecomodeller
Copy link
Member Author

ecomodeller commented May 24, 2024

@jsmariegaard Merging this PR broke some tests in modelskill related to skill 😐

FAILED tests/test_config.py::test_comparison_from_yml - assert 0.2330094096313094 == 0.2331039 ± 2.3e-07
FAILED tests/test_multivariable_compare.py::test_mv_skill - assert 0.2249234222997736 ± 2.2e-07 == 0.22792652
FAILED tests/test_multivariable_compare.py::test_mv_mm_skill - assert 1.3053589704786461 ± 1.3e-06 == 1.5610323
FAILED tests/test_multivariable_compare.py::test_mv_mm_mean_skill - assert 0.643293404624024 ± 6.4e-07 == 0.6246696
FAILED tests/test_pointcompare.py::test_score - assert 0.19863716489592623 == 0.19870695 ± 2.0e-07

But I suppose the expected scores are actually not correct, since the default algorithm is to use IDW interpolation and the nearest elements are out of order, but this needs to be verified.
image
image

@jsmariegaard
Copy link
Member

Hmm, something for next week...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dfsu read elements reordered
2 participants