-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add triangle to convexity helper #1717
base: master
Are you sure you want to change the base?
Add triangle to convexity helper #1717
Conversation
…ToConvexityHelper
PythonTests fail but it seems unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a minor comment
It looks like "testConvexityHelper" fails in the CI bots. |
Curiously it is working on my Mac Debug/Release. Do you have an ubuntu to tell me what's happening ? |
On a linux docker image:
|
Hi @JacquesOlivierLachaud , were you able to reproduce the bug ? |
Sorry I haven't found any time to work on it (and I forgot at some point :) ) . I will come back to it soon. |
PR Description
Add specific methods in ConvexityHelper and DigitalConvexity to build lattice polytope from 2 or 3 points, even in degenerate cases. This speeds up their construction by a factor 3 to 5.
Checklist