Prevent DailyCalendar from Removing Hour from Timestamps #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinElms
changed the title
JustinElms
added
the
Priority: High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The hours listed in the hourly timepicker dropdown were getting repalced by "00:00" whenever the date was changed via the calendar or the prev/next buttons. This was because the
DailyCalendarcomponent was erasing the time data when generating the date buttons for the calendar dropdown and because this data was only a shallow copy the changes were reflected in the dataset timestamps. To resolve this issue a deep copy of the timestamps was created within this component to prevent the original timestamp data from getting modified.Why did you take this approach?
Keeps the functionality without modifying the original data.
Screenshot(s)
Checks
black ..