Rename unforbid to claim #695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Penumbra69
commented
May 2, 2023
•
Penumbra69
commented
- closes dfhack #3183
- unforbid.lua -> claim.lua
- unforbid.rst -> claim.rst
- update documentation to use claim / claimed
- Update "forbid.lua" to hint at "claim all" instead of "unforbid all"
- added a note to the changelog.txt
- unforbid.lua -> claim.lua - unforbid.rst -> claim.rst - update documentation to use claim / claimed - Update "forbid.lua" to hint at "claim all" - added a note to the changelog.txt - Added an alias "unforbid -> claim" in the init
myk002
reviewed
May 2, 2023
- Adding _unforbid anchor Co-authored-by: Myk <myk.taylor@gmail.com>
- Trying to make sphinx happy
|
the sphinx anchor has to be above a title. I think the verification script needs to be updated in this case. The logic in this line would need to detect and skip over anchor definitions (lines starting with |
- Skip anchors (..) - Anchor unforbid docs to claim.rst
|
I see now .. I haven't used Sphinx in a v. long time - I think I hive it sorted out this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.