Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unforbid to claim #3183

Open
myk002 opened this issue Apr 8, 2023 · 2 comments · May be fixed by DFHack/scripts#695
Open

Rename unforbid to claim #3183

myk002 opened this issue Apr 8, 2023 · 2 comments · May be fixed by DFHack/scripts#695

Comments

@myk002
Copy link
Member

myk002 commented Apr 8, 2023

and add an alias for unforbid -> claim so the old name continues to work

ref: https://discord.com/channels/793331351645323264/1017471248567124049/1091810230972723230

@Penumbra69
Copy link

Penumbra69 commented May 2, 2023

This looks like some good low hanging fruit for me to begin with.

Looks like this is:

  • Renaming "unforbid.lua" -> "claim.lua" (along with all of the internal references).
  • Renaming "unforbid.rst" -> "claim.rst" (along with all of the internal spellings)
  • Adding an alias to "dfhack.tools.init" for the "unforbid -> claim" backwards compatible usage

If this is correct, I can push the PR.

Q: Do we want to change "unforbid*" in other places?
I see it being used client facing in "forbid.lua" as well as "makeown.lua", "stripcaged.rst" and "kitchen-info.lua".

@Penumbra69
Copy link

Penumbra69 commented May 2, 2023

I think strpcaged.rst and kitchen-info is fine, upon re-reading it.. It makes sense in context there.
I think forbid.lua should update with this so there's parity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants