Make changevein affect connected veins #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
May 16, 2024
plugins/changevein.cpp
Outdated
| { | ||
| for (uint8_t j = 0; j < 15; j++) | ||
| { | ||
| uint16_t bitmask = cur->tile_bitmask.bits[j] | cur->tile_bitmask.bits[std::max(j - 1, 0)] | cur->tile_bitmask.bits[std::min(j + 1, 15)]; |
There was a problem hiding this comment.
isn't j-1 == 255 since it's a uint8_t and has a starting value of 0?
There was a problem hiding this comment.
Great catch! Got used to using uint as if it was an int and didn't notice.
plugins/changevein.cpp
Outdated
Comment on lines
153
to
155
| for (size_t j = 0; j < newBlock->block_events.size(); j++) | ||
| { | ||
| df::block_square_event* evt = newBlock->block_events[j]; |
There was a problem hiding this comment.
Suggested change
| for (size_t j = 0; j < newBlock->block_events.size(); j++) | |
| { | |
| df::block_square_event* evt = newBlock->block_events[j]; | |
| for (auto evt : newBlock->block_events) | |
| { |
There was a problem hiding this comment.
same for other similar for loops in this file. the original code was written before this syntax was available in C++, but there's no reason not to use the modern syntax
myk002
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4519
changevein will now convert any connected veins in the same tile and neighboring tiles.