Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hotkey (Shift+R) to call the markdown script #4470

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Add hotkey (Shift+R) to call the markdown script #4470

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d71c9d4
Add hotkey (Shift+R) to call the markdown script
glotov4 Apr 15, 2024
836dcb7
Apply suggestions from code review
myk002 Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions data/init/dfhack.keybindings.init
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ keybinding add Ctrl-Shift-K gui/cp437-table
# customizable quick command list
keybinding add Ctrl-Shift-A gui/quickcmd

# save the description of a selected unit or item to the `/markdown_{YourWorldName}.md` file in the root game directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starting a filename with a slash indicates that it will be saved in the root folder of the entire system, not the current directory. I'd remove that leading slash.

myk002 marked this conversation as resolved.
Show resolved Hide resolved
keybinding add Shift-R@dwarfmode/ViewSheets/UNIT|dwarfmode/ViewSheet markdown
Copy link
Member

@myk002 myk002 Apr 15, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm vary wary about adding a binding to regular text keys. It can cause non-obvious problems with text entry. For example, it would prevent a squad from having a name with a capital R in it (or, if the key is allowed through, the player would export the item description every time they typed R):
image

I suggest Alt-R instead

dwarfmode/ViewSheet

I think this got truncated. This is supposed to be dwarfmode/ViewSheets/ITEM, right?

Also, please move this down to the dwarfmode section below.

myk002 marked this conversation as resolved.
Show resolved Hide resolved


###################
# embark bindings #
Expand Down