Ensure job applications cannot be submitted with unexplained gaps in employment #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://teaching-vacancies-review-pr-6759.test.teacherservices.cloud on AKS |
KyleMacPherson
force-pushed
the
validate-no-gaps
branch
from
0c1ebac
to
c682298
Compare
…t on job applications
KyleMacPherson
force-pushed
the
validate-no-gaps
branch
from
a135b74
to
1c887f3
Compare
KyleMacPherson
force-pushed
the
validate-no-gaps
branch
from
1c887f3
to
7cbe68b
Compare
KyleMacPherson
force-pushed
the
validate-no-gaps
branch
from
7cbe68b
to
a283e72
Compare
KyleMacPherson
commented
Mar 27, 2024
| click_on "Add another job" | ||
| fill_in_current_role(start_year: jobseeker_profile.employments.first.ended_on.year.to_s, start_month: jobseeker_profile.employments.first.ended_on.month.to_s) | ||
| click_on "Save role" | ||
|
|
There was a problem hiding this comment.
Changes in unrelated tests are filling in gaps in job applications so that they pass the new validation
KyleMacPherson
force-pushed
the
validate-no-gaps
branch
from
715b493
to
d69da4f
Compare
KyleMacPherson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/b/1QyLnb9W/teaching-vacancies-sprint-board
Changes in this PR:
This PR adds validation on the job application form which stops jobseekers being able to create job applications with unexplained gaps in their work history.
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?