Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #88 #89

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Resolves #88 #89

wants to merge 3 commits into from

Conversation

jtmyles
Copy link
Contributor

@jtmyles jtmyles commented Feb 7, 2022

Resolves issue #88

  • replace fitsio usage with astropy
  • replace missing redmapper files at server linked in the notebook (no change to code necessary)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

This was referenced Feb 13, 2022
@cylammarco cylammarco added the dependencies Pull requests that update a dependency file label Feb 13, 2022
@michaelJwilson
Copy link
Contributor

Flagging the issue specifically, I believe I saw something similarly locally aswell. @jtmyles this notebook looked good to you?

https://github.com/michaelJwilson/desihigh/blob/13f423afc4ac4a0404b1b39771d75fb18523e4df/Clusters.ipynb

image

@jtmyles
Copy link
Contributor Author

jtmyles commented Feb 17, 2022

It looks like the notebook file in 13f423a had zero bytes. I've attempted to add it again. Now I see the notebook having the right size. When I clone the repository into a new directory on a new machine it looks right to me, so I believe the issues are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants