Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiple sensor queries #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

satta
Copy link
Member

@satta satta commented May 28, 2019

This PR addresses #35, allowing a query for more than one sensor ID in the entries() query. This is backwards compatible, since

query {
  entries(rdata:"1.2.3.4", sensor_id:["foo"]) {
    rrname
    sensor_id
  }
}

seems to be equivalent to

query {
  entries(rdata:"1.2.3.4", sensor_id:"foo") {
    rrname
    sensor_id
  }
}

which matches the previously used syntax.

@satta satta changed the title WIP: add support for multiple sensor queries add support for multiple sensor queries May 28, 2019
@satta satta requested a review from magenbluten June 20, 2019 12:48
@magenbluten
Copy link
Contributor

maybe we should somewhere document that the limit is per sensor, i.e. if you query for 5 sensors with a limit of 100 you could get up to 500 results.

@satta
Copy link
Member Author

satta commented Jul 13, 2019

maybe we should somewhere document that the limit is per sensor, i.e. if you query for 5 sensors with a limit of 100 you could get up to 500 results.

Well, it's not per sensor at the moment! The implementation in this PR treats the limit parameter as describing the sum of all results.

@satta satta removed the request for review from magenbluten September 23, 2019 21:32
@satta
Copy link
Member Author

satta commented Oct 2, 2019

Do we want to merge this or not? Any comments? Suggestions? Would it be more intuitive (@petromoldovan?) if we had a limit per sensor?

@satta satta added the enhancement New feature or request label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants