movescu's --bit-preserving option is not respecting the --output-directory option (issue #1122) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplest attempt at correcting issue #1122. When movescu is called with +B (--bit-preserving) option, the output file ends up in the current working directory as opposed to the desired output directory even if you add the -od (--output-directory) option in the command line. Note that a better approach could be to have a singular writing function and adjust the function signatures to pass whether other processing logic should be skipped. However, that could cause a lot of headaches ensuring all logic paths are checked against the current bit-preserving behavior of outputting the data as-is. I leave the option to the maintainer if to request further work to address this issue more comprehensively or if the change proposed here is good enough for the project. The changes here appears to work as intended in my test environment.
Stylistic correction to comments
Unlike movescu, storescp does not recompute the file path in the storeSCP callback. It assumes that imageFileName already includes the directory name. However, I separated the imageFileName generation from the full path generation, so I realized I needed to correct the deleteFile logic as well. Will need to do something like this in movescu to ensure consistency across both codebases.
Keeping consistency between movescu and storescp so they both look at the file path in a similar manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplest attempt at correcting issue #1122.
When movescu is called with +B (--bit-preserving) option, the output file ends up in the current working directory as opposed to the desired output directory even if you add the -od (--output-directory) option in the command line.
Note that a better approach could be to have a singular writing function and adjust the function signatures to pass whether other processing logic should be skipped. However, that could cause a lot of headaches ensuring all logic paths are checked against the current bit-preserving behavior of outputting the data as-is.
I leave the option to the maintainer if to request further work to address this issue more comprehensively or if the change proposed here is good enough for the project.
The changes here work as intended in my test environment.
https://support.dcmtk.org/redmine/issues/1122