Support for optional fractional part of a second #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:setISOFormattedDateTime and OFTime::setISOFormattedTime
|
Thank you for your contribution! Not sure whether we will apply the patch directly (or adjust it a little bit...) but in any case you'll be mentioned as the original author/contributor. Since we currently have no time to check your patch in detail, I've added the following entry to DCMTK's issue tracker (so your proposed patch doesn't get lost): https://support.dcmtk.org/redmine/issues/895 |
|
Thats okay let me know if i can help with the patch adaptation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have reworked OFTime::setISOFormattedTime and modified OFDateTime::setISOFormattedDateTime
new parser is very simple - old school char by char state machine :) but it works
Thanks!