Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/aps timeseries #88

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

DCMSstats
Copy link
Collaborator

Hi Matt,

This might be my last pull request but I might try and update the Rmd file tomorrow with some instructions on how to use + add some tests - will send a follow up email. Just wanted to get the last bits of work I had done so far on here for my successor/you/another to pick up!

Thanks,
Niall

Copy link
Collaborator

@ivyleavedtoadflax ivyleavedtoadflax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great I'll take a look...If you get time to add tests and some test data, that would really help me get my head around what the functions do!

@ivyleavedtoadflax
Copy link
Collaborator

Think probably I would do away with APS_utils.R. The lookup functions probably want to be handled as lookup tables that are bundled as data objects in the package, and the other functions can get rolled into the main utils.R file.

@ivyleavedtoadflax ivyleavedtoadflax changed the title Feature/aps timeseries [WIP] Feature/aps timeseries Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants