#2410: Round out the Fund model with UI #2824
Open
+285
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameron-hicks
changed the title
|
looking pretty sharp so far from a skim! @cameron-hicks let me know if/when you'd like either me or Kat to take a deeper look but otherwise we'll wait until this is marked ready for review. Nice to have you back! |
cameron-hicks
force-pushed
the
feature/fund-read-update-view
branch
from
af9560b
to
4e5370d
Compare
cameron-hicks
changed the title
cameron-hicks
force-pushed
the
feature/fund-read-update-view
branch
from
4e5370d
to
4da0c1c
Compare
cameron-hicks
force-pushed
the
feature/fund-read-update-view
branch
from
7a7478e
to
79b588e
Compare
|
finally got an evening to return to this one! sorry it's so old! I think I've got all the specs passing but we shall see what CI does... @colinxfleming @lomky |
|
I see a couple linters failed, I'll fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
FundsControllerTODO:
It relates to the following issue #s:
For reviewer:
featureif it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.dependenciesif it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.