Skip to content

Commit

Permalink
Update cran-comments.Rmd
Browse files Browse the repository at this point in the history
  • Loading branch information
stefvanbuuren committed May 12, 2020
1 parent 7de60d7 commit c676f39
Show file tree
Hide file tree
Showing 2 changed files with 99 additions and 69 deletions.
83 changes: 49 additions & 34 deletions cran-comments.Rmd
Expand Up @@ -3,13 +3,13 @@ title: "cran-comments"
output: github_document
---

## Reason
## Reason for update

Request from CRAN because of breaking change in `tibble 3.0.0`
`dscore 1.3.0` introduces new functionality and solves some problems

## Test environments

* local OS X install, 10.15.4, R 3.6.2
* local OS X install, 10.15.4, R 4.0.0
* win-builder, using `devtools::check_win_devel()`
* rhub

Expand All @@ -23,18 +23,11 @@ build(manual = TRUE)
```

```{bash eval=FALSE}
R CMD CHECK /Users/buurensv/Package/dscore/dscore_1.2.0.tar.gz
R CMD CHECK /Users/buurensv/Package/dscore/dscore_1.3.0.tar.gz
...
* checking data for non-ASCII characters ... NOTE
Note: found 3 marked UTF-8 strings
...
Status: 1 NOTE
Status: OK
```

UTF-8 codes are supported by CRAN, so I assume we can ignore the note.

### WIN_DEVEL

`devtools::check_win_devel()` resulted in:
Expand All @@ -52,45 +45,67 @@ check_rhub()
The result is:

```
── dscore 1.2.0: NOTE
── dscore 1.3.0: ERROR
Build ID: dscore_1.2.0.tar.gz-ace2b0cbcddd4eb980f5659a20a2c170
Build ID: dscore_1.3.0.tar.gz-6c32ff0b664f45338fe9902216505e74
Platform: Windows Server 2008 R2 SP1, R-devel, 32/64 bit
Submitted: 7m 50s ago
Build time: 7m 32s
Submitted: 6m 29.3s ago
Build time: 6m 26s
checking examples ...
** running examples for arch 'i386' ... ERROR
Running examples in 'dscore-Ex.R' failed
The error most likely occurred in:
> ### Name: get_age_equivalent
> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Title: Get age equivalents of items that have a difficulty estimate
>
> ### ** Examples
> ### Aliases: get_age_equivalent
>
Error in loadNamespace(name) : there is no package called 'utf8'
```

> checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
'dscore-Ex_i386.Rout' 'dscore-Ex_x64.Rout' 'examples_i386'
'examples_x64' 'tests_i386' 'tests_x64'
The solution of this problem is outside my reach.

0 errors ✓ | 0 warnings ✓ | 1 note x
```
── dscore 1.3.0: OK
Build ID: dscore_1.3.0.tar.gz-56b28c78bf1045d386e3fda917897383
Platform: Ubuntu Linux 16.04 LTS, R-release, GCC
Submitted: 28 minutes 49.8 seconds ago
Build time: 28 minutes 48.9 seconds
```
── dscore 1.2.0: OK

Build ID: dscore_1.2.0.tar.gz-b23ec143969242e49a6f750f640a28f4
Platform: Ubuntu Linux 16.04 LTS, R-release, GCC
```
OK

```
── dscore 1.2.0: OK
── dscore 1.3.0: OK
Build ID: dscore_1.2.0.tar.gz-e8125f39d6dd48ea8c54610080f7c200
Platform: Fedora Linux, R-devel, clang, gfortran
Build ID: dscore_1.3.0.tar.gz-b47f1ead4d784a42b7c747eae6e66f7c
Platform: Fedora Linux, R-devel, clang, gfortran
Submitted: 34 minutes 23.5 seconds ago
Build time: 34 minutes 22.8 seconds
```

```
── dscore 1.2.0: PREPERROR
OK

STATUS: success
```
── dscore 1.3.0: PREPERROR
Build ID: dscore_1.3.0.tar.gz-4557c74d8e6c4c36a2635e6d04f75f8b
Platform: Debian Linux, R-devel, GCC ASAN/UBSAN
Submitted: 59 minutes 50.4 seconds ago
Build time: 59 minutes 48.4 seconds
Build ID: dscore_1.2.0.tar.gz-12c76df788da4dc7a782826f051d749c
Platform: Debian Linux, R-devel, GCC ASAN/UBSAN
...
Build step 'Send files or execute commands over SSH' changed build result to SUCCESS
Pinging https://builder.r-hub.io/build/SUCCESS/dscore_1.3.0.tar.gz-4557c74d8e6c4c36a2635e6d04f75f8b/2020-05-12T14:53:59Z
{"status":"ok"}
Finished: SUCCESS
```

I believe none of the messages is caused by the `dscore` package.
The banner says `PREPERROR` but the logs say `SUCCESS`

## Downstream dependencies

Expand Down
85 changes: 50 additions & 35 deletions cran-comments.md
@@ -1,13 +1,13 @@
cran-comments
================

## Reason
## Reason for update

Request from CRAN because of breaking change in `tibble 3.0.0`
`dscore 1.3.0` introduces new functionality and solves some problems

## Test environments

- local OS X install, 10.15.4, R 3.6.2
- local OS X install, 10.15.4, R 4.0.0
- win-builder, using `devtools::check_win_devel()`
- rhub

Expand All @@ -21,18 +21,11 @@ build(manual = TRUE)
```

``` bash
R CMD CHECK /Users/buurensv/Package/dscore/dscore_1.2.0.tar.gz
R CMD CHECK /Users/buurensv/Package/dscore/dscore_1.3.0.tar.gz

...
* checking data for non-ASCII characters ... NOTE
Note: found 3 marked UTF-8 strings
...

Status: 1 NOTE
Status: OK
```

UTF-8 codes are supported by CRAN, so I assume we can ignore the note.

### WIN\_DEVEL

`devtools::check_win_devel()` resulted in:
Expand All @@ -47,38 +40,60 @@ check_rhub()

The result is:

── dscore 1.2.0: NOTE
── dscore 1.3.0: ERROR

Build ID: dscore_1.2.0.tar.gz-ace2b0cbcddd4eb980f5659a20a2c170
Build ID: dscore_1.3.0.tar.gz-6c32ff0b664f45338fe9902216505e74
Platform: Windows Server 2008 R2 SP1, R-devel, 32/64 bit
Submitted: 7m 50s ago
Build time: 7m 32s
Submitted: 6m 29.3s ago
Build time: 6m 26s

> checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
'dscore-Ex_i386.Rout' 'dscore-Ex_x64.Rout' 'examples_i386'
'examples_x64' 'tests_i386' 'tests_x64'
checking examples ...
** running examples for arch 'i386' ... ERROR
Running examples in 'dscore-Ex.R' failed
The error most likely occurred in:
> ### Name: get_age_equivalent
> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Title: Get age equivalents of items that have a difficulty estimate
>
> ### ** Examples
> ### Aliases: get_age_equivalent
>
Error in loadNamespace(name) : there is no package called 'utf8'

The solution of this problem is outside my reach.

── dscore 1.3.0: OK

0 errors ✓ | 0 warnings ✓ | 1 note x
Build ID: dscore_1.3.0.tar.gz-56b28c78bf1045d386e3fda917897383
Platform: Ubuntu Linux 16.04 LTS, R-release, GCC
Submitted: 28 minutes 49.8 seconds ago
Build time: 28 minutes 48.9 seconds

── dscore 1.2.0: OK

Build ID: dscore_1.2.0.tar.gz-b23ec143969242e49a6f750f640a28f4
Platform: Ubuntu Linux 16.04 LTS, R-release, GCC

── dscore 1.2.0: OK

Build ID: dscore_1.2.0.tar.gz-e8125f39d6dd48ea8c54610080f7c200
Platform: Fedora Linux, R-devel, clang, gfortran
OK

── dscore 1.2.0: PREPERROR
── dscore 1.3.0: OK

STATUS: success
Build ID: dscore_1.3.0.tar.gz-b47f1ead4d784a42b7c747eae6e66f7c
Platform: Fedora Linux, R-devel, clang, gfortran
Submitted: 34 minutes 23.5 seconds ago
Build time: 34 minutes 22.8 seconds

OK

── dscore 1.3.0: PREPERROR
Build ID: dscore_1.3.0.tar.gz-4557c74d8e6c4c36a2635e6d04f75f8b
Platform: Debian Linux, R-devel, GCC ASAN/UBSAN
Submitted: 59 minutes 50.4 seconds ago
Build time: 59 minutes 48.4 seconds

Build ID: dscore_1.2.0.tar.gz-12c76df788da4dc7a782826f051d749c
Platform: Debian Linux, R-devel, GCC ASAN/UBSAN
...
Build step 'Send files or execute commands over SSH' changed build result to SUCCESS
Pinging https://builder.r-hub.io/build/SUCCESS/dscore_1.3.0.tar.gz-4557c74d8e6c4c36a2635e6d04f75f8b/2020-05-12T14:53:59Z
{"status":"ok"}
Finished: SUCCESS

I believe none of the messages is caused by the `dscore` package.
The banner says `PREPERROR` but the logs say `SUCCESS`

## Downstream dependencies

Expand Down

0 comments on commit c676f39

Please sign in to comment.