[370]Merge useful functions from serverless experiment #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luongthomas
reviewed
Apr 11, 2019
luongthomas
reviewed
Apr 11, 2019
luongthomas
requested changes
Apr 11, 2019
AndrewScibek
force-pushed
the
370-dns-corpus-merge
branch
from
0ee2a68
to
f87c340
Compare
AndrewScibek
commented
Apr 22, 2019
| @@ -1,8 +1,7 @@ | |||
| FROM python:3.7-slim | |||
| FROM python:3.7 | |||
There was a problem hiding this comment.
stephenprater
approved these changes
Apr 22, 2019
luongthomas
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes does this PR introduce?
Load secrets from vault on app startup, consul dns, move corpus into repo
Any background context you want to provide?
These were useful functions made while exploring serverless
Where should the reviewer start?
init.py
Has this been manually tested? How?
pytest
What GIF best describes this PR or how it makes you feel?