feat(1.6): extend EvidenceOccurrence #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
requested changes
May 9, 2024
mcombuechen
force-pushed
the
156-evidence-occurrence
branch
from
c5fe752
to
501c5ef
Compare
mcombuechen
commented
May 12, 2024
There was a problem hiding this comment.
@nscuro thanks for your change request. While applying the changes, I got some linter warning that suggested the conversion sub-routine was not really doing what it was supposed to. I added a unit test, and really it was broken. Changed the signature, now it's working.
I have some thoughts on the type definitions of LineNumber and Offset, maybe you have a good idea how we can solve the challenges that come with these numbers.
Closes CycloneDX#156. Signed-off-by: Maximilian Combüchen <max.combuchen@snyk.io>
mcombuechen
force-pushed
the
156-evidence-occurrence
branch
from
501c5ef
to
b1636c2
Compare
nscuro
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends type
EvidenceOccurrencewith additional fields from the 1.6 spec. Logic has been added to the conversion to make sure they don't show up in lower spec versions.Closes #156.