Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to best get rid of slice pointers #21

Open
nscuro opened this issue Feb 8, 2022 · 1 comment
Open

Investigate how to best get rid of slice pointers #21

nscuro opened this issue Feb 8, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@nscuro
Copy link
Member

nscuro commented Feb 8, 2022

Currently, we're using slice pointers (e.g. *[]string) to work around a limitation of encoding/xml.

It works, but it's not pretty. This is painfully obvious when trying to iterate over elements of those slices and having to dereference and nil check all the time. It'd be great if we could just have normal slices instead.

Most likely, we'll have to introduce a lot more custom (de-)serialization code specific to the XML format to make this work.

@nscuro nscuro added this to the v1.0.0 milestone Feb 8, 2022
@nscuro nscuro added the enhancement New feature or request label Feb 8, 2022
@nscuro nscuro added the help wanted Extra attention is needed label Jul 27, 2023
@ragaskar
Copy link

Is it known if anyone is actively working on this?

If not, and I have some spare time (in short supply for me at the moment, but you never know...) I might take a shot at fixing this, since as a user (thanks for this lib, by the way!!!!) I definitely feel the rough edges caused by these pointers. Just don't want to duplicate efforts if someone else is already working on this problem 😁 .

I imagine any extra existing context would be helpful too (e.g., "I tried doing it but it was harder than I thought because X, Y or Z").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants