Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all eth* flagged mgmt_itf #273

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sohorx
Copy link
Contributor

@sohorx sohorx commented Sep 19, 2023

Issue:

I encountered an issue with VLAN interfaces based on eth* interfaces in ifupdown2. Currently, these interfaces are treated differently from other interface types, resulting in MTU discrepancies.

Consider the following configuration:

iface eth1 inet static
    address 1.1.1.1/32
    mtu 2000

iface eth1.1212 inet static
    address 2.2.2.2/32

This results in the eth1.1212 MTU being 1500 instead of 2000.

Management Interface Handling:

What I understand is that interfaces prefixed with "eth" are considered Management Interfaces by ifupdown2 (these interfaces do not have MTU configured resulting in my issue).

Management interface prefixes are configurable in a policy JSON file. However, I believe that ens3 and eth1 interfaces should not have different default handling.

Proposed Changes:

Now, with this PR, "None" is being configured and allowed as the Management Interface prefix, making both ens3 and eth1 behave the same way by default.

Users can then customize their policies to handle eth-prefixed interfaces as they did before.

Additional Suggestion:

Furthermore, I think making a policy using regex might be more useful and less error-prone than a simple "startswith".

this commit goal is to improve readabilty
Setting eth as a default prefix for MGM_ITF flag make handling behave
oddly, ens1 and eth1 should not have a handling diff.
@sohorx
Copy link
Contributor Author

sohorx commented Oct 9, 2023

I have updated the PR description in an effort to make it more understandable.

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant