Issue #16 - memory access queue font color #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 20, 2017 12:32
… doesnt have the dark theme
…lue/dark blue colors
|
|
jbonzo
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having a lot of difficulties changing the font color on the md-data-table element and stumbling upon this issue:
daniel-nagy/md-data-table#153
It turns out that this element doesn't play well with dark themes since the styling for the table is hardcoded into the CSS, apparently there is an open PR to fix this but it hasn't been merged yet:
daniel-nagy/md-data-table#607
The current fix I've added on this PR changes just the memory access queue area to a light background, which fixes the issue but isn't the most attractive solution IMO:
There is also another option (NOT in this PR) to change the entire sidebar to a light theme:
So we can decide amongst ourselves which of these two would be preferred for the time being.