Reject invalid Postgres user specs #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
commented
Apr 22, 2024
cbandy
force-pushed
the
options-validation
branch
2 times, most recently
from
20b62fe
to
6b30161
Compare
These values will be rejected in the future. Issue: PGO-1094
This uses a Postgres SQL parser to remove the PASSWORD option and any SQL comments. These values will be rejected in the future. Issue: PGO-1094
The PASSWORD option was never effective. CEL validation rules, available in beta since Kubernetes 1.25, can detect and reject values that the RE2 pattern validation of "github.com/go-openapi" could not. Issue: PGO-1094 See: https://pkg.go.dev/github.com/go-openapi/validate@v0.24.0#hdr-Known_limitations
cbandy
force-pushed
the
options-validation
branch
from
6b30161
to
820c10a
Compare
tjmoore4
approved these changes
Apr 24, 2024
|
|
||
| "github.com/crunchydata/postgres-operator/internal/logging" | ||
| "github.com/crunchydata/postgres-operator/pkg/apis/postgres-operator.crunchydata.com/v1beta1" | ||
| ) | ||
|
|
||
| func sanitizeAlterRoleOptions(options string) string { | ||
| const AlterRolePrefix = `ALTER ROLE "any" WITH ` |
There was a problem hiding this comment.
🤔 Just to make sure I understand, since you're just passing in the options and not the entire statement, you have to append this prefix in order to use the GetAlterRoleStmt().GetOptions() functions of pg_query. Or is there more to it than that?
There was a problem hiding this comment.
Exactly right. The parser works only on complete statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PASSWORD option was never effective. CEL validation rules, available in beta since Kubernetes 1.25, can detect and reject values that the RE2 pattern validation of github.com/go-openapi could not.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
The PASSWORD option and SQL comments are accepted in Postgres user specs on the PostgresCluster object.
What is the new behavior (if this is a feature change)?
These values are now rejected at the Kubernetes API and removed before being sent to Postgres.
A new package checks CRD validation using envtest.
Other Information:
Issue: PGO-1094