Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pgadmin basic service #3893

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Pgadmin basic service #3893

merged 5 commits into from
Apr 24, 2024

Conversation

jmckulk
Copy link
Collaborator

@jmckulk jmckulk commented Apr 16, 2024

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:

@jmckulk jmckulk force-pushed the pgadmin_basic_service branch 5 times, most recently from d217183 to bdc45de Compare April 19, 2024 19:49
@jmckulk jmckulk marked this pull request as ready for review April 19, 2024 21:28
tjmoore4
tjmoore4 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tjmoore4 tjmoore4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few nitpicks and question, but no blockers.

pkg/apis/postgres-operator.crunchydata.com/v1beta1/standalone_pgadmin_types.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/service.go Outdated Show resolved Hide resolved
internal/naming/labels.go Outdated Show resolved Hide resolved
internal/naming/labels.go Outdated Show resolved Hide resolved
@jmckulk
Update pgAdmin labeling
4a6ed36 
- Define label and selector functions
- Ensure use of label functions
@jmckulk
Update reconciling log messages
d7d6abf 
Now both the "reconciling" and "reconciled" log messages are debug logs
and use the same terms/cases
@jmckulk
Allow require.Namespace to run from subtest
5d6ccea
@jmckulk
Add controlled delete for pgAdmin
853d482
@jmckulk
Create ClusterIP service through spec
326bd1a 
Allow users to create a ClusterIP service by setting the ServiceName
field in the spec
@jmckulk jmckulk merged commit 4cba701 into CrunchyData:master Apr 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjmoore4 tjmoore4 tjmoore4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmckulk @tjmoore4