Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OpenLayers from v6.1.1 to v8.2.0 #145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JakobMiksch
Copy link
Contributor

@dr-jts
Copy link
Collaborator

dr-jts commented Oct 17, 2023

Perhaps OpenLayers should just be vendored in, to avoid external dependencies?

@JakobMiksch
Copy link
Contributor Author

JakobMiksch commented Oct 21, 2023

Perhaps OpenLayers should just be vendored in, to avoid external dependencies?

@dr-jts True, how would you prefer to do that?
I see these options:

  • add a minified version of the OL library (+CSS) to the git of the project. It has the advantage, that pg_featureserv can start immediately, but checking in a dependency in to git is not always preferred
  • the OL library (+CSS) needs to be downloaded when the program is built or it has do be done (semi-)manually by the person who starts a local dev setup. we might night a little script for that (or maybe go has some inbuilt functionality (?) ). The advantage is that the OL dependency stays out of the project's source code

@JakobMiksch
Copy link
Contributor Author

JakobMiksch commented Feb 22, 2024

@dr-jts I upgraded this PR to OpenLayers 8.2.0.
I like the idea of keeping the library of OpenLayers directly in pg_feature. However, I think this should be a separate issue.
What do you think, can we merge this PR first?

@JakobMiksch JakobMiksch changed the title Upgrade OpenLayers from v6.1.1 to v8.1.0 Upgrade OpenLayers from v6.1.1 to v8.2.0 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants