Extend relationship with attributes between parent and child entity #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
martin-fleck-at
commented
Mar 7, 2024
martin-fleck-at
commented
- Add relationship attribute support in grammar
- Provide only correct attributes as suggestion to the user
- Validate to only have correct attributes and no duplicates
- Add relationship attribute support in grammar - Provide only correct attributes as suggestion to the user - Validate to only have correct attributes and no duplicates
martin-fleck-at
force-pushed
the
feature/relationship-attribute
branch
from
aac61bc
to
87d0e88
Compare
harmen-xb
reviewed
Mar 8, 2024
There was a problem hiding this comment.
@martin-fleck-at The PR looks quite good. I added some inline comments.
As just discusses we both agree here the crossmodel grammer can be simplified where the arbitrary order of the properties won't be supported anymore.
extensions/crossmodel-lang/src/language-server/cross-model-validator.ts
Outdated
Show resolved
Hide resolved
extensions/crossmodel-lang/src/language-server/cross-model-validator.ts
Outdated
Show resolved
Hide resolved
extensions/crossmodel-lang/src/language-server/relationship.langium
Outdated
Show resolved
Hide resolved
- Slightly improve completion provider - Fix up test cases with newly specified mandatory properties
martin-fleck-at
force-pushed
the
feature/relationship-attribute
branch
from
67eb8ad
to
4cb931c
Compare
harmen-xb
approved these changes
Mar 15, 2024
extensions/crossmodel-lang/test/language-server/cross-model-lang-diagram.test.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.