Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiling issue in raster_tile.py #452

Open
wants to merge 13 commits into
base: 0.5.0
Choose a base branch
from

Conversation

srmsoumya
Copy link
Collaborator

Description

Raster tiler is missing a few tiles while creating the chips. Rounding the profile["transform"] to 3 decimal places is creating the issue of chips overwrite, changing this to 6 decimal places fixes the issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My PR has a descriptive title
  • My code follows PEP8
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors
  • I have added tests that prove my fix is effective or that my feature works
  • My PR passes Travis CI tests
  • My PR does not reduce coverage in Codecov

If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

SRM added 2 commits February 1, 2022 19:06
Rounding off the profile['transform'] to 3 decimal places
is leading to overwrite of some tiles while saving the chips.
@srmsoumya srmsoumya requested a review from rbavery March 2, 2022 11:41
Copy link
Contributor

@rbavery rbavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that status checks are showing it's clear tests are not passing yet. This is strange, because they pass when I run them using make test locally. I think we need to align our gh action testing with our local testing. @srmsoumya @rodrigoalmeida94 I'm off for the day but if either of you get a chance can you investigate why tests are not passing on gh actions but they are with make test?

.github/workflows/tests.yml Show resolved Hide resolved
requirements-test.txt Outdated Show resolved Hide resolved
solaris/__init__.py Show resolved Hide resolved
solaris/tile/raster_tile.py Show resolved Hide resolved
@srmsoumya
Copy link
Collaborator Author

srmsoumya commented Mar 17, 2022

@rbavery I was able to reproduce the test errors locally.

The array values are different for tiles in

  • tests/data/rastertile_test_fill_nodata_expected/
  • tests/data/rastertile_test_fill_nodata_result/

Visually they look similar but array values are different.
eg:
Screenshot 2022-03-17 at 6 31 15 PM

We are just changing the precision for file names, everything else remains the same.
Is it because we changed from

-  opencv-python>=4.1
+  opencv>=4.5.5

@rbavery
Copy link
Contributor

rbavery commented Jun 30, 2022

@srmsoumya looking at your recent commit and just a heads up, using opencv appears to be what works for recent releases so I think we should stick to that. See #461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants