IBC Callbacks #1817
Draft
IBC Callbacks #1817
+531
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
force-pushed
the
ibc-callbacks
branch
3 times, most recently
from
bd3eab3
to
692b398
Compare
srdtrk
reviewed
Apr 30, 2024
| ack ibcexported.Acknowledgement, | ||
| contractAddress string, | ||
| ) error { | ||
| // sender validation makes no sense here, as the receiver is never the sender |
There was a problem hiding this comment.
Yes, it might be good to document that probably the contract itself should be doing some validation based on the channel-id and packet data possibly.
It might even make sense to have the contract whitelist certain channel-ids to be able to receive callbacks only on those channels (but this is a nice to have and can make the UX more complicated).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.